Do not assign offsetgroup to traces in px unless barmode="group"
#4865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, not using Without See comparison below — I believe the behavior on
|
emilykl
changed the title
offsetgroup to traces in px unless barmode="grouped"
emilykl
changed the title
offsetgroup to traces in px unless barmode="grouped"offsetgroup to traces in px unless barmode="group"
emilykl
requested review from
LiamConnors,
archmoj,
gvwilson and
marthacryan
|
Note: The 4 visual changes in Percy are the 4 charts which were incorrect on |
|
thanks @emilykl - @marthacryan please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4863
This change is required due to the change in behavior for
offsetgroupintroduced in Plotly.js 3.0: plotly/plotly.js#7009The above change causes bars to appear as a group if
offsetgroupis set, even ifbarmodeis set tostacked, which changes the default behavior of histograms and bar charts, as explained in #4863 (see comment).This PR fixes the issue by only setting
offsetgroupifbarmode="group". (We also setoffsetgroupifbarmodeis not set, sincegroupis the default barmode in Plotly.js.)Note that we can't remove setting
offsetgroupentirely due to the issue described in my comment here.The other change (changing the point at which we set
barmodetooverlayif the figure has marginal histograms) is so that the figure'sbarmodein that case will be set before the point where we decide whether to setoffsetgroup.